Skip to content

Conversation

@joboet
Copy link
Member

@joboet joboet commented Mar 21, 2025

This can be faster for iterators where an optimized try_fold implementation is available.

r? libs-api

This can be faster for iterators where an optimized `try_fold` implementation is available.
@joboet joboet added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 21, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2025
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#19 exporting to docker image format
#19 sending tarball 21.3s done
#19 DONE 27.5s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
[RUSTC-TIMING] build_script_build test:false 0.293
error[E0277]: the size for values of type `Self` cannot be known at compilation time
    --> library/core/src/iter/traits/iterator.rs:299:24
     |
299  |             match self.try_fold(n, |n, item| {
     |                        ^^^^^^^^ doesn't have a size known at compile-time
     |
note: required by a bound in `iterator::Iterator::try_fold`
    --> library/core/src/iter/traits/iterator.rs:2385:15
     |
2383 |     fn try_fold<B, F, R>(&mut self, init: B, mut f: F) -> R
     |        -------- required by a bound in this associated function
2384 |     where
2385 |         Self: Sized,
     |               ^^^^^ required by this bound in `Iterator::try_fold`
help: consider further restricting `Self`
     |
296  |     fn advance_by(&mut self, n: usize) -> Result<(), NonZero<usize>> where Self: marker::Sized {
     |                                                                      +++++++++++++++++++++++++

For more information about this error, try `rustc --explain E0277`.
[RUSTC-TIMING] core test:false 7.498
error: could not compile `core` (lib) due to 1 previous error

@joboet joboet closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants